Repository navigation
Conversation
Signed-off-by: jayyyyqwq <jaychoukiker@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
🎉 Welcome to the Kubeflow SDK! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
OptimizerClient.get_job_eventssays in its docstring that it raisesRuntimeErrorif getting the events fails. In the Kubernetes backend only the timeout is handled, so any other error fromlist_namespaced_event(for example a 403 when the user cannot list events) comes out as the raw Kubernetes error.The other methods in this backend already do it, for example
list_jobshasexcept Exceptionand raisesRuntimeError. I added the same forget_job_events.I added a test that makes
list_namespaced_eventfail. On main (ee22b33) the timeout case passes and the other case fails withException: events are forbidden. With the change both pass. The existing "timeout" test for events goes throughget_jobfirst, so it never reached the events call.I noticed
TrainerClient.get_job_eventshas the same docstring and the same gap in the Trainer Kubernetes backend. I left it out to keep this small. Should I send that as a separate PR, or add it here?Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):None.
Checklist: