Repository navigation
feat(trainer): preview TrainJob before submission - #895
Open
RobuRishabh wants to merge 1 commit into
Open
RobuRishabh wants to merge 1 commit into
RobuRishabh wants to merge 1 commit into
Conversation
Add TrainerClient.preview_train_job() to inspect the exact Kubernetes TrainJob resource without creating it. Reuse a shared resource builder for preview and submission, document preview limitations, and reject unsupported backends. Add tests ensuring preview performs no create request and matches the submitted body when using a fixed job name. Signed-off-by: roburishabh <roburishabh@outlook.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
Hello @robert-bell can I get your review/thoughts here, PTAL. Thanks |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds
TrainerClient.preview_train_job()for inspecting the exact Kubernetes TrainJob resource before submission.Preview and submission now share the same resource builder. Preview performs no create request, while runtime resolution may still read from the cluster. Unsupported backends raise
NotImplementedError.The API documentation clarifies that a fixed
Nameoption is required to compare separate preview and submission calls and that preview does not perform server-side validation.Which issue(s) this PR fixes:
Fixes #847
Checklist: