Skip to content

fix(docker): support multi-arch build for kubectl-delivery image - #3078

Merged
andreyvelich merged 1 commit into
kubeflow:release-1.9from
jsl9208:fix/kubectl-multiarch
Jan 9, 2026
Merged

andreyvelich merged 1 commit into
kubeflow:release-1.9from
jsl9208:fix/kubectl-multiarch

Conversation

@jsl9208

@jsl9208 jsl9208 commented Jan 9, 2026 •

Copy link
Copy Markdown

What this PR does / why we need it:
This PR enables multi-architecture build support (e.g., for linux/arm64) for the kubectl-delivery image in the v1 codebase.

Currently, the Dockerfile has the architecture hardcoded to amd64. This prevents users on ARM-based systems from building or using this image with the v1 trainer.

Changes:

  • Added ARG TARGETARCH.
  • Replaced hardcoded amd64 with ${TARGETARCH} in the download URL.

Testing: I have verified the build locally using docker buildx:
docker buildx build --platform linux/amd64,linux/arm64 -t kubectl-delivery:multiarch .

Signed-off-by: jsl9208 <jiangshilong9208@gmail.com>
@github-actions

github-actions Bot commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

🎉 Welcome to the Kubeflow Trainer! 🎉

Thanks for opening your first PR! We're happy to have you as part of our community 🚀

Here's what happens next:

  • If you haven't already, please check out our Contributing Guide for repo-specific guidelines and the Kubeflow Contributor Guide for general community standards.
  • Our team will review your PR soon! cc @kubeflow/kubeflow-trainer-team

Join the community:

Feel free to ask questions in the comments if you need any help or clarification!
Thanks again for contributing to Kubeflow! 🙏

@astefanutti

astefanutti commented Jan 9, 2026 •

Copy link
Copy Markdown
Contributor

@jsl9208 thanks!

The JAX integration tests are failing but it doesn't look related to your changes.

/lgtm

/assign @kubeflow/kubeflow-trainer-team

@andreyvelich andreyvelich left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thanks @jsl9208!

@andreyvelich
andreyvelich merged commit 9e12c68 into kubeflow:release-1.9 Jan 9, 2026
48 of 58 checks passed
@google-oss-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants