Repository navigation
fix(docker): support multi-arch build for kubectl-delivery image - #3078
Conversation
Signed-off-by: jsl9208 <jiangshilong9208@gmail.com>
|
🎉 Welcome to the Kubeflow Trainer! 🎉 Thanks for opening your first PR! We're happy to have you as part of our community 🚀 Here's what happens next:
Join the community:
Feel free to ask questions in the comments if you need any help or clarification! |
|
@jsl9208 thanks! The JAX integration tests are failing but it doesn't look related to your changes. /lgtm /assign @kubeflow/kubeflow-trainer-team |
andreyvelich
left a comment
There was a problem hiding this comment.
/lgtm
/approve
Thanks @jsl9208!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR enables multi-architecture build support (e.g., for linux/arm64) for the kubectl-delivery image in the v1 codebase.
Currently, the Dockerfile has the architecture hardcoded to
amd64. This prevents users on ARM-based systems from building or using this image with the v1 trainer.Changes:
ARG TARGETARCH.${TARGETARCH}in the download URL.Testing: I have verified the build locally using docker buildx:
docker buildx build --platform linux/amd64,linux/arm64 -t kubectl-delivery:multiarch .