Repository navigation
fix(apply): preserve FileKeyRef when converting env vars - #4289
Closed
DevaanshPathak wants to merge 1 commit into
Closed
DevaanshPathak wants to merge 1 commit into
DevaanshPathak wants to merge 1 commit into
Conversation
TrainJob trainer env already accepts valueFrom.fileKeyRef, but apply.EnvVar dropped it (and fieldRef.apiVersion) before the JobSet was applied. Fixes kubeflow#4288 Signed-off-by: DevaanshPathak <devaanshpathak08@gmail.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
@andreyvelich: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
valueFrom.fileKeyRefinapply.EnvVarso TrainJob trainer/initializer env vars survive conversion onto the JobSet.fieldRef.apiVersionon the same path.Fixes #4288
Test plan
go test ./pkg/apply/ -count=1