Repository navigation
chore(scripts): use go.mod go version for generation - #4295
Merged
google-oss-prow[bot] merged 1 commit intoOct 22, 2026
Merged
Conversation
Signed-off-by: Rob Bell <robell@redhat.com>
Member
Author
|
/cc @andreyvelich Just a small QOL fix. I don't think there's any need to backport this but it'll be useful for the next go upgrade. |
andreyvelich
left a comment
andreyvelich
left a comment
Member
There was a problem hiding this comment.
Thanks @robert-bell!
/lgtm
/approve
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This change sets
GOTOOLCHAINformake generateand its prerequisites to the version from the go directive in go.mod, matching CI’s Go version selection. This ensures thatmake generateuses the same go version as what's being used in CI.While working on an older branch, I found that
make generateran locally with Go 1.27 due to the recent upgrade, but CI continued to use Go 1.26 producing different generated output causing CI to fail.Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #4294
Checklist: