spark-operator: Update Notebooks integration to use Enterprise Gateway 3.3.0 defaults - #4437
spark-operator: Update Notebooks integration to use Enterprise Gateway 3.3.0 defaults#4437Ramneek-kalra wants to merge 1 commit into
Conversation
spark-operator: Update Notebooks integration to use Enterprise Gateway 3.3.0 defaults Use the Jupyter Enterprise Gateway Helm chart defaults instead of a custom values file, and bump the install from 3.2.3 to 3.3.0. Also remove the PVC-mounted kernelspecs guidance, which is easy to misconfigure and is not needed because spark_python_operator ships with the chart defaults. Signed-off-by: Ramneek kalraramneekhmr@gmail.com Signed-off-by: Ramneek Kalra <kalraramneekhmr@gmail.com>
|
Hi @Ramneek-kalra. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
|
Hi @yuchaoran2011 — could you take a look when you have a chance, and |
|
🚫 This command cannot be processed. Only organization members or owners can use the commands. |
|
I think we should probably not suggest people use the
Lets discuss this in slack about how we can update the "how to integrate notebook and spark operator" to use the SDK. |
|
@thesuperzapper > Few questions as I tried exploring SDK today as per the use-case we need and what kind of things might differ from not using Jupyter Enterprise Gateway: Use-Case:
What we tried today?
Questions:
Looking forward to hearing from you next. Thanks! |
|
@vikas-saxena02 who will present it at the Kubeflow virtual event. We will remove the enterprise gateway and replace it with the official SDK way. |
|
/close |
|
@juliusvonkohout: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vikas-saxena02 may you replace the enterprise gateway with the official way in the documentation ? |
Hi @thesuperzapper , i 100% agree with you and for scala users Apache Toree as a kernel introduces a lot of vulnerabilities in the overall solution. I am, presenting a talk in Kubeflow Virtual Syposium where I am presenting SparkConnect as the alternative where we can use Almond and have users use that as an out of box solution. This way we will cut dependency on jupyter enterprise gateway for sure. if I can get some guidance on how to present it as a proposal to wider community, it would be of great help. PS: Julius already know about the solution. cc: @chasecadet @andreyvelich @nabuskey @franciscojavierarceo @vjanelle |
|
@vikas-saxena02 Once the test in the community distribution is there you can mostly delete theis page and just link to the test. |
1 similar comment
|
@vikas-saxena02 Once the test in the community distribution is there you can mostly delete theis page and just link to the test. |
@juliusvonkohout i was thinking of doing a proper documentation as this is valid usecase for many people. think its better to do a proper documentation and then will provide link to the tests as well. |
|
Documentation has to be maintained at costs and automation is the best documentation. So please keep it short and focus on the high level then and for the implementation link to the test. |
Summary
Updates the Integration with Kubeflow Notebooks guide so the Jupyter Enterprise Gateway install matches current chart defaults and the latest release.
Fixes: #
Motivation
The current docs pin Jupyter Enterprise Gateway to
3.2.3and ask readers to deploy with a customvalues.yaml. That custom config, plus the PVC /hostPathkernelspecs mount path, caused real install friction: mounted kernelspecs were not detected reliably.The Enterprise Gateway Helm chart already:
elyra/enterprise-gateway:3.3.0andelyra/kernel-image-puller:3.3.0spark_python_operatorinkernel.allowedKernelskernelspecsPvc.enabled: falseby defaultSo the docs should install with chart defaults and avoid recommending PVC-mounted kernelspecs for the common path.
Changes
3.2.3→3.3.0enterprise-gateway-helm.yamlinstall with the default chart install (no--valuesoverride)--set kernel.defaultKernelName=spark_python_operatorif readers want that kernel as defaulthostPathkernelspecs customization stepsspark_python_operator(waspyspark)Test plan
v3.3.03.3.0spark_python_operator