fix: dedupe exposed ports with normalized protocols

[immanuwell]

Fixes a tiny duplicate-port edge case

Repro before this patch:

services:
  app:
    image: nginx
    ports:
      - "80"
    expose:
      - "80"
      - "8080"

ports comes from compose-go as tcp, while expose defaults to TCP, so the dedupe key missed and emitted 80/TCP twice. not great.

This normalizes protocols before checking the key, so 80/TCP is kept once and 8080/TCP still gets added.

Related history: #1070 / #1223 fixed another duplicate-port path; this is the ports+expose version.

Tested:

go test ./...

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: immanuwell / name: immanuwell (c7e0b0d)

[k8s-ci-robot]

Welcome @immanuwell!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: immanuwell
Once this PR has been reviewed and has the lgtm label, please assign cdrage for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[HaraldNordgren]

Makes sense!

[immanuwell]

@HaraldNordgren just rebaised this PR and now also all CI checks should be green
PTAL

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: HaraldNordgren, immanuwell
Once this PR has been reviewed and has the lgtm label, please assign cdrage for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cdrage]

So sorry been a delay in reviews!

Can you please add a unit test as well?

These are typically added to this folder: https://github.com/kubernetes/kompose/tree/main/script/test/fixtures