Skip to content

fix: ensure unique mountPath when service has multiple secrets - #2104

Open
fru1tworld wants to merge 2 commits into
kubernetes:mainfrom
fru1tworld:fix/1894-multi-secret-mountpath
Open

fix: ensure unique mountPath when service has multiple secrets#2104
fru1tworld wants to merge 2 commits into
kubernetes:mainfrom
fru1tworld:fix/1894-multi-secret-mountpath

Conversation

@fru1tworld

Copy link
Copy Markdown

What type of PR is this?

/kind bug

What this PR does / why we need it:

When a service references multiple secrets, compose-go normalizes
short-syntax secrets: [a, b] to long-syntax with
Target="/run/secrets/<name>". getSecretPathsLegacy then stripped the
filename and used only the parent directory as mountPath, so both
secrets ended up with mountPath: /run/secrets and kubectl apply failed
with volumeMounts[*].mountPath: must be unique.

Use the full target as the mountPath. SubPath still selects the file
within the secret data, so the file lands at the same location.

Which issue(s) this PR fixes:

Fixes #1894

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 13, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented May 13, 2026

Copy link
Copy Markdown

CLA Signed
The committers listed above are authorized under a signed CLA.

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Welcome @fru1tworld!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fru1tworld
Once this PR has been reviewed and has the lgtm label, please assign cdrage for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
k8s-ci-robot requested review from TessaIO and cdrage May 13, 2026 02:23
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 13, 2026
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Multiple secrets for single service result in non-unique "mountPath" error

2 participants