Repository navigation
Conversation
Reads ~/.copilot/session-state/<id>/events.jsonl (COPILOT_HOME aware). Skips sub-agent events and harness-injected user messages.
[Medium impact] The PR appears safe to merge; the previous finding is fully fixed. Reviews (4) · Last reviewed commit: "fix: drop agents that also reject Window..." · Reviewed by Greptile |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Speaking as Kun's firstmate: thanks @markbosch for the Copilot CLI adapter. It's a clean, fail-soft read-only adapter with a pinned fixture, which is exactly how VISION wants new harnesses added. I reviewed the diff and approved the fork CI runs. Build-and-test passes on ubuntu and macOS, and the generated-files guard passes. This is waiting on you: the required Once that's green, this goes to Kun for a decision rather than auto-merge. Adding |
What Changed
copilotdiscovery adapter that reads~/.copilot/session-state/<uuid>/events.jsonland ties sessions to a repo throughsession.startcwd/gitRoot. It is registered inALL_HARNESSES, the discovery index, the SSH probe and bundle, and the TUI render. README now lists eight harnesses.copilotinharness-invoke.js. They go through an argv wrapper that passes--model,--reasoning-effortand--acp --stdio, and are refused on Windows or whencopilotis not on PATH. Also added acopilot loginhint inagents.js.copilot-session.jsonl) with adapter tests, a config test update, andharness-invoke-copilottests.Risk Assessment
✅ Low: This adds a fail-soft read-only Copilot discovery adapter and an invocation-scoped model/effort wrapper that follow the existing grok and pi patterns, and I found no concrete defects.
Testing
I ran the real backpass CLI scan against a disposable Copilot session store and repo. The copilot harness row showed 1 scanned and 1 matched, with the session classified as interactive and associated by cwd at tier 1. With a missing store it exited 0 and the copilot row did not appear in the output at all, rather than failing. The targeted adapter, harness-invoke and config tests also passed. I did not drive a model call through the
copilotbinary, so the model/effort flag wiring is covered only by those unit tests.Evidence: scan with Copilot session
Evidence: scan with missing store
Evidence: targeted tests
Pipeline
Updates from git push no-mistakes
⏭️ **Intent** - skipped
Step was skipped.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
node bin/backpass.js scanin a disposable git repo, withCOPILOT_HOMEpointing at a synthetic copy of the test/fixtures/copilot-session.jsonl fixturenode bin/backpass.js scanwithCOPILOT_HOMEpointing at a nonexistent directorynode --test test/adapters.test.js test/harness-invoke-copilot.test.js test/config.test.js(60 tests passed)✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.