Skip to content

draft QA: Windows SIGKILL Codex recovery test portability (for upstream #18139) #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kvnloo wants to merge 2 commits into
base: review/base-t3-codex-recovery-20261012
Choose a base branch
from
Draft

draft QA: Windows SIGKILL Codex recovery test portability (for upstream #18139) #36

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a1b350
test(codex): accept Windows nonzero SIGKILL exit and use service subpath
kvnloo Oct 12, 2026
5dee3a7
test(fork): include hosted Codex QA workflow in candidate branch
kvnloo Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions apps/server/src/orchestration-v2/Adapters/CodexSessionRecovery.integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ import * as Option from "effect/Option";
import * as Path from "effect/Path";
import * as Schema from "effect/Schema";
import * as Stream from "effect/Stream";
import { ChildProcess, ChildProcessSpawner } from "effect/process";
import { ChildProcess } from "effect/process";
import * as ChildProcessSpawner from "effect/process/ChildProcessSpawner";

import * as ServerConfig from "../../config.ts";
import * as ProviderEventLoggers from "@t3tools/provider-core/server/ProviderEventLoggers";
Expand Down Expand Up @@ -150,8 +151,14 @@ describe("Codex shared session recovery", () => {
);
}
const exit = yield* Effect.exit(handle.exitCode);
assert.equal(Exit.isFailure(exit), termination === "SIGKILL");
if (Exit.isSuccess(exit)) assert.equal(Number(exit.value), 7);
if (termination === "exit code") {
assert.isTrue(Exit.isSuccess(exit));
if (Exit.isSuccess(exit)) assert.equal(Number(exit.value), 7);
} else if (Exit.isSuccess(exit)) {
// Windows may report a nonzero exit code after SIGKILL instead of
// failing the exitCode Effect, unlike POSIX.
assert.notEqual(Number(exit.value), 0);
}

// Await committed failures, rather than guessing when the event pump ran.
yield* eventSink
Expand Down
Loading