Repository navigation
fix: expand experience card budgets and report exact size failures - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Raise the full stored experience-card limit and the product catalog detail-response limit from 2 KiB to 4 KiB. Keep catalog/input/action budgets and the one-detail-read allowance unchanged; reserve text space for program-generated metadata in the extraction prompt.
Report invalid_card_size with needed_bytes, limit_bytes and exceeded_bytes measured after all validated references, normalized tags and controlled triggers are added. Propagate numeric diagnostics to CLI, events and the learn trace span without echoing model content.
Validation: related offline regression 142 passed / 1 skipped; trace viewer 8 passed. Tests cover a valid 2308-byte card writing and reading, exact 4096/4097 boundaries, final metadata measurement, CLI/event/trace propagation and unchanged main results. No live provider, real 8906 rerun or full-suite rerun claimed. See docs/reviews/2026-10-12-experience-card-budget-acceptance.md.