Skip to content
This repository was archived by the owner on Apr 24, 2024. It is now read-only.
This repository was archived by the owner on Apr 24, 2024. It is now read-only.

Change ridge's cholesky solver from scipy.linalg.solve(assume_a='pos') to scipy.linalg.cholesky #36

Description

@agoscinski

In PR #31 we using scipy.linalg.solve with argument assuma_a='pos', to reproduce this with torch however we should use scipy.linalg.cholesky so we can replace it later with equistore operations. This needs a bit additional work (how some additional postprocessing, checking if the scipy and torch solvers bring similar accuracy), so we deal with this in a new PR.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions