fix(sandbox): preserve workspace-local Skill symlinks - #155
Merged
Merged
Conversation
zjy365
approved these changes
Sep 10, 2026
norberia
force-pushed
the
codex/preserve-workspace-skill-symlinks
branch
from
September 10, 2026 07:13
7827d9e to
c09d2d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploying repositories such as actualbudget/actual fails during Skill preparation because their
.agents/skillsentries alias directories under.claude/skills. The preparer applies the image bundle's no-symlinks rule to these repository-owned files and aborts before agent execution.This change validates repository Skill links separately and preserves their original link text during staging. Links must resolve within the workspace; dangling links, link/directory cycles, special files and symlinked roots remain rejected. Image bundle integrity checks remain unchanged. Replacing a same-named bundled Skill removes only the alias, leaving its repository destination intact.
Recovery scans transaction contents without following links, restores the backup to its live location and validates destinations before preparing again. This avoids resolving relative aliases from temporary stage/backup paths. Regression coverage includes Actual-style aliases, nested escapes, repeated preparation, replacement, legacy recovery and SIGKILL after backup/publication.
Validation:
node --test base-images/frameworks/sandbox/v1/skill-bundle*.test.mjs— 29 passed.node base-images/frameworks/sandbox/v1/verify-pinned-source.mjs— passed against the existing pinned Skills revision; 3 Skills / 13 files.git diff --check— passed.No image build/publication, Skills revision update, or Brain configuration change is included. Container/production validation remains for the later image rollout.