Skip to content

ci: update GitHub Actions for Node 24 #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaruesink merged 2 commits into from
Jul 28, 2026
Merged

ci: update GitHub Actions for Node 24 #184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf468e7
ci: update actions for Node 24
jaruesink Jul 28, 2026
2c5ab2b
fix: satisfy biome formatting check
jaruesink Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/github-pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5

- name: Setup Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v5
with:
node-version: '22.9.0'

Expand Down
12 changes: 7 additions & 5 deletions .github/workflows/pr-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ on:
# Sets permissions of the GITHUB_TOKEN to allow deployment to GitHub Pages
permissions:
contents: read
issues: write

@coderabbitai coderabbitai Bot Jul 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔒 Security & Privacy | 🟠 Major | ⚡ Quick win

Scope issues: write to the comment job.

issues: write is workflow-wide here, so the build and cleanup jobs also inherit issue-write access even though the fork guard only skips the API call in the comment step. Move the comment logic into a dedicated same-repo job with job-level issues: write.

🧰 Tools
🪛 zizmor (1.26.1)

[error] 14-14: overly broad permissions (excessive-permissions): issues: write is overly broad at the workflow level

(excessive-permissions)

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/pr-preview.yml at line 14, Move the comment logic in the
workflow into a dedicated same-repository comment job and relocate the issues:
write permission from workflow scope to that job’s permissions. Keep build and
cleanup jobs limited to their existing permissions, and preserve the fork guard
around the comment API call.

pages: write
id-token: write
pull-requests: write
Expand All @@ -29,10 +30,10 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5

- name: Setup Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v5
with:
node-version: '22.9.0'

Expand Down Expand Up @@ -60,7 +61,8 @@ jobs:

# Add a comment to the PR with the preview URL
- name: Comment PR
uses: actions/github-script@v6
if: github.event.pull_request.head.repo.full_name == github.repository
uses: actions/github-script@v8
with:
script: |
const previewUrl = `https://lambda-curry.github.io/forms/pr-${context.issue.number}/`;
Expand Down Expand Up @@ -143,7 +145,7 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
ref: gh-pages

Expand All @@ -164,4 +166,4 @@ jobs:
git push
else
echo "PR preview directory not found"
fi
fi
6 changes: 3 additions & 3 deletions .github/workflows/pr-quality-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,12 @@ jobs:
timeout-minutes: 15
steps:
- name: Checkout code
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0

- name: Setup Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v5
with:
node-version: '22.9.0'

Expand All @@ -43,7 +43,7 @@ jobs:
run: yarn install

- name: Cache Turbo
uses: actions/cache@v4
uses: actions/cache@v5
with:
path: .turbo
key: ${{ runner.os }}-turbo-${{ github.ref_name }}-${{ hashFiles('**/yarn.lock') }}-${{ github.sha }}
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout Repo
uses: actions/checkout@v4
uses: actions/checkout@v5

- name: Setup Node.js
uses: actions/setup-node@v4
uses: actions/setup-node@v5
Comment on lines +20 to +23

@coderabbitai coderabbitai Bot Jul 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Show the relevant workflow region with line numbers.
file=".github/workflows/release.yml"
wc -l "$file"
sed -n '1,80p' "$file" | cat -n

Repository: lambda-curry/forms

Length of output: 3150

Update the stale setup-node reference. The comment at the release step still says setup-node@v4, but this workflow now uses actions/setup-node@v5.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/release.yml around lines 20 - 23, Update the stale
setup-node reference in the release workflow comment to say
actions/setup-node@v5, matching the version used by the Setup Node.js step.

with:
node-version: '22'
registry-url: 'https://registry.npmjs.org'
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,12 @@ jobs:

steps:
- name: Checkout
uses: actions/checkout@v4
uses: actions/checkout@v5
with:
fetch-depth: 0

- name: Setup Node.js
uses: actions/setup-node@v3
uses: actions/setup-node@v5
with:
node-version: '22.9.0'

Expand All @@ -44,4 +44,3 @@ jobs:
name: test-failure
path: packages/components/storybook-static
retention-days: 2

6 changes: 5 additions & 1 deletion packages/components/src/ui/checkbox-field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,11 @@ const CheckboxField = ({

return (
<FormItem
className={cn('flex flex-row gap-3 space-y-0', hasSupportingText ? 'items-start' : 'items-center', className)}
className={cn(
'flex flex-row gap-3 space-y-0',
hasSupportingText ? 'items-start' : 'items-center',
className,
)}
>
<FormControl Component={components?.FormControl}>
<CheckboxComponent
Expand Down
Loading