Skip to content

fix(datafusion): normalize signed zero in remaining filters #9323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lance-gatefixer wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(datafusion): normalize signed zero in remaining filters #9323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4270ba
fix(datafusion): normalize signed zero in remaining filters
lance-gatefixer[bot] Sep 16, 2026
b95e7dc
fix(datafusion): register signed-zero UDF for Substrait
lance-gatefixer[bot] Sep 16, 2026
f351ad4
fix(datafusion): evaluate array_has haystack once
lance-gatefixer[bot] Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rust/lance-datafusion/src/planner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1078,7 +1078,7 @@ impl Planner {
// Running the rewrite more than once is safe because its output is a fixed
// point of `optimize_expr`; `optimizing_twice_changes_nothing` pins that.
let expr = simplifier.simplify(expr)?;
let expr = rewrite_signed_zero_comparisons(expr)?;
let expr = rewrite_signed_zero_comparisons(expr, &df_schema)?;

Ok(expr)
}
Expand Down
Loading
Loading