Skip to content

refactor(index): expose RaBitQ encoding and factor primitives - #9832

Merged
BubbleCal merged 2 commits into
mainfrom
yang/layered-rq-encoding-primitives
Oct 10, 2026
Merged

BubbleCal merged 2 commits into
mainfrom
yang/layered-rq-encoding-primitives

Conversation

@BubbleCal

@BubbleCal BubbleCal commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Expose the encoding and raw-query factor primitives used by Layered RQ. The existing encoding entry points retain their behavior.

Dependencies

Independent PR targeting main. Integrated main ec857edd1d15, retaining the native scratch reuse and fused factor pipeline. The public explicit-scale API uses the same quantization loop and scale search as native encoding.

Validation

On macOS arm64 with Rust 1.97.0 after main integration:

  • cargo +1.97.0 fmt --all -- --check
  • cargo +1.97.0 test --locked -p lance-index vector::bq: 440 passed, including explicit-scale parity and invalid-norm cases
  • cargo +1.97.0 clippy --locked --all --tests --benches -- -D warnings

No new performance measurement is claimed; CI is not awaited.

Tracking

OSS-2347

@github-actions github-actions Bot added the A-index Vector index, linalg, tokenizer label Oct 9, 2026
@BubbleCal
BubbleCal force-pushed the yang/layered-rq-encoding-primitives branch from 6ce5093 to 90c0415 Compare October 9, 2026 14:13
@BubbleCal
BubbleCal force-pushed the yang/layered-rq-fused-kernels branch from 51edac7 to 4f43856 Compare October 9, 2026 14:13
@BubbleCal
BubbleCal force-pushed the yang/layered-rq-fused-kernels branch from 4f43856 to a9f3adc Compare October 9, 2026 16:48
@BubbleCal
BubbleCal force-pushed the yang/layered-rq-encoding-primitives branch from 90c0415 to 689ea17 Compare October 9, 2026 16:48
@BubbleCal
BubbleCal force-pushed the yang/layered-rq-encoding-primitives branch from 689ea17 to 09e9c00 Compare October 9, 2026 18:55
@BubbleCal
BubbleCal force-pushed the yang/layered-rq-fused-kernels branch from a9f3adc to 1a31588 Compare October 9, 2026 18:55
@BubbleCal
BubbleCal changed the base branch from yang/layered-rq-fused-kernels to main October 9, 2026 18:56
@BubbleCal
BubbleCal marked this pull request as ready for review October 10, 2026 11:11

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@lance-gatekeeper lance-gatekeeper Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Gate recommendation: approve.

No merge-blocking issues found. All 441 focused RaBitQ tests passed, including explicit-scale parity and fused-factor comparisons.

@lance-gatekeeper lance-gatekeeper Bot added the K-approved Latest Gatekeeper recommendation permits acceptance. label Oct 10, 2026
@BubbleCal
BubbleCal merged commit de7c3a0 into main Oct 10, 2026
39 of 41 checks passed
@BubbleCal
BubbleCal deleted the yang/layered-rq-encoding-primitives branch October 10, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-index Vector index, linalg, tokenizer K-approved Latest Gatekeeper recommendation permits acceptance.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants