Repository navigation
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recognize Windows path separators when inferring skill access from tool calls. The current detector matches
/SKILL.mdandskills/.../scripts/only, so a successful Windows read such asGet-Content C:\Users\dev\.codex\skills\pdf\SKILL.mdis missed. The same command with forward slashes is recognized.This also affects Windows paths escaped inside
execJavaScript source, where two literal backslashes can appear in the captured tool input.Change
Verification
On Windows, Node 24.14.0 with the repository-pinned pnpm 9.5.0:
[]instead of["pdf"]; the five existing skill tests passed.pnpm run lintpassed (formatting and TypeScript).586910c81eeaf21d8f54c1c86c89a29a5466c1efon the same machine: 117 passed / the same 4 failed. These are threehook-command.test.tscases and the sessions-tree indexing case intrace.test.ts; no skips or assertions were weakened.Local setup notes: used a process-local pnpm 9.5.0 launcher because nested scripts otherwise resolved the machine's pnpm 11; restored canonical Git line endings in this isolated checkout for Prettier. No lockfile or unrelated file changes are included.
Scope
This repairs separator recognition, not proof of successful/effective skill use. The detector still infers from input text and can tag failed reads or incidental path mentions; changing that meaning should be a separate change. Fixtures are synthetic and contain no private transcripts, credentials or account identifiers. The installed plugin and tracing configuration were not modified.