Repository navigation
fix(openai_api_compatible): forward reasoning_effort without thinking toggle - #3832
Souravrajvi0 wants to merge 4 commits into
Conversation
… toggle The Chat Completions path only re-added reasoning_effort when enable_thinking was explicitly true, so the standard OpenAI parameter was silently dropped in the default "Both Modes" configuration. Forward the top-level parameter whenever thinking is not forced off, while keeping the chat_template_kwargs mirror gated on extended mode and an explicit thinking toggle. Fixes langgenius#3827
|
Please fix CI errors. @Souravrajvi0 |
|
@Mairuis CI was failing at Check Release Notes. I added a |
…ging main Main already shipped 0.0.65, so this release needs the next version for the reasoning_effort forwarding fix.
|
Thank you for your contribution, @Souravrajvi0! This PR currently has merge conflicts with If these changes are still wanted, they can be folded into #3869 when you update it. |
Summary
Fixes #3827.
The Chat Completions path popped
reasoning_effortfrom model parameters but only re-added it whenenable_thinkingwas explicitlytrue. In the default "Both Modes" configuration (thinking toggle off), the standard OpenAI parameter was silently dropped from outgoing requests.This change forwards the top-level
reasoning_effortwhenever thinking is not forced off (enable_thinking_value is not False), matching the Responses API path and the issue's suggested fix. The non-standardchat_template_kwargsmirror remains gated on extended compatibility mode and an explicit thinking toggle.Bump plugin version to
0.0.66.Release Notes
reasoning_effortparameter when the thinking toggle is off in "Both Modes".reasoning_effortwhenever thinking is not explicitly forced off, matching the Responses API behavior.chat_template_kwargsmirror gated on extended compatibility mode and an explicit thinking toggle.Change Type
Test plan
test_reasoning_effort_forwarding.pycovering:reasoning_effortreasoning_effortnot_supported) still dropsreasoning_effortonly_thinking_supported) forwardsreasoning_effortchat_template_kwargsonly when thinking is explicitly enableduv run pytest tests/test_reasoning_effort_forwarding.py -vpasses (6/6)main, local tests on the updated branch pass