Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4159.
Preserve the supplied content and regular expression instead of stripping them before matching. A literal-space pattern currently becomes an empty pattern, while anchored whitespace and trailing newlines disappear from the input. The runtime fix removes the two
strip()calls and retains the existing result format and regex engine.Release Notes
Fix Regex Extract discarding significant spaces, tabs and newlines from input content and regular expressions.
Change Type
Screenshots / Videos
Real SDK and packaged-plugin HTTP reproductions:
a b c/ a single spacea foo b/foo['foo'][' foo ']foo\n/\n$[]['\n']Version
dify_plugin>=0.10.2,<0.11.0and update its lock metadata; no locked dependency versions changed.Testing
uv run --locked --with pytest==9.0.2 python -m pytest tests -q: 10 passed.git diff --checkpasses./healthreturns 200; HTTP/invokepreserves spaces and trailing newlines, with an ordinary digit-extraction control. The same space-pattern HTTP assertion fails on the unchanged baseline. Probe processes are stopped after each run.