Repository navigation
fix: give the agent a short sign-in link in Each user signs in mode (1.0.1) - #4184
Closed
ForeignKeyCN wants to merge 1 commit into
Closed
ForeignKeyCN wants to merge 1 commit into
ForeignKeyCN wants to merge 1 commit into
Conversation
Applies to outlook, teams, onedrive, microsoft_excel_365, microsoft_todo, sharepoint, jira, confluence, trello and google_calendar. In "Each user signs in" mode the agent retypes the sign-in link in its reply, and a long random state does not always survive that: in a real chat one character changed case, so the callback endpoint could not recognize the sign-in. The tool now returns <sign-in endpoint>?start=<12 lowercase characters without look-alikes>, and the endpoint redirects to the sign-in page it stored. The state and PKCE values go to the provider and back without passing through the agent.
Contributor
📄 Knowledge review✏️ Suggested updates3 page suggestions need review.
|
3 of 5 tasks
Contributor
Author
|
Moved into #4186 together with the other change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In Each user signs in mode, the tool returns a sign-in link and the agent passes it on to the user in its reply. The agent retypes the link rather than copying it, and a long random value does not always survive that. In a real chat, one character of the
stateparameter changed case (...X3FQbecame...X3fQ), so the callback endpoint showed "Sign-in link not recognized".Fix
<sign-in endpoint>?start=<id>.idis 12 lowercase characters without look-alikes (0/o,1/l).stateand PKCE values go to the provider and come back without passing through the agent.Nothing changes for administrators: same endpoint, same redirect URI, same credential.
Plugins (1.0.0 → 1.0.1)
outlook, teams, onedrive, microsoft_excel_365, microsoft_todo, sharepoint, jira, confluence, trello, google_calendar
The open PRs for gmail (#4180), google_drive_tool (#4181) and google_sheets (#4182) already include the same change.
Tests