Repository navigation
Conversation
WH-2099
marked this pull request as ready for review
October 13, 2026 15:51
6 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SDK calls could leave response resources open, interleave TCP frames, or leave CLI readers blocked after process exit.
This change fixes those lifecycle paths and expands regression coverage while preserving existing SDK behavior against
mainat86e81e72.Closes #394.
Changes
The tests cover all 37 public dispatch actions, actual local HTTP/TLS services, sockets, subprocess pipes, cancellation and an installed SDK wheel.
Dispatch assertions inspect the arguments received by plugin implementations, including credentials and user/session context.
CLI assertions cover complete request envelopes and the daemon's error format.
The test guide records upstream source revisions and fixture limitations; controlled mutations were used to check that key assertions detect incorrect behavior.
Development dependencies add pytest-httpserver, pytest-timeout, pytest-socket, Hypothesis and trustme.
TLS certificates are generated in memory, with temporary files where Python TLS APIs require paths.
The private-key check retains its default configuration.
just coveragecombines parent and subprocess coverage and writes JUnit, JSON and XML reports underreports/.Separate SDK, runtime and HTTP coverage gates remain enforced.
Compatibility
The target is
main, with existing behavior pinned to86e81e72.Package version remains
0.11.0; runtime dependencies and the supported Python version range are unchanged.The review checks public signatures and provider extension hooks against the baseline.
Compatibility regressions cover:
Existing limitations are retained deliberately.
For example, a 4 MiB datasource or Agent blob can exceed the daemon's default 5 MiB JSON line limit after base64 encoding.
Changing that transport or the model scoring policy requires a separate compatible design.
The test guide describes compatibility coverage and protocol evidence.
The regression map links behavior to its tests.
Validation
just coverage, 1,470 passed, with no failed or skipped tests.just check,just build,just docs, all prek hooks andgit diff --checkpassed.Tests use local services and the actual SDK wheel.
The matrix used fresh pytest temporary roots because gevent 26.9.0 can exhaust file descriptors when removing large historical temporary directories.
A running Dify deployment, the released Go CLI, external model APIs and sustained load were not tested.
Pull Request Checklist
Compatibility Check
README.mdREADME.mdREADME.md— not applicable: existing behavior is preserved against the baseline above.README.mdAvailable Checks
just buildhas passed