Skip to content

refactor(dataset): replace available_segment_count property with get_available_segment_count(session) #42523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asukaminato0721 merged 4 commits into from
Sep 21, 2026
Merged

refactor(dataset): replace available_segment_count property with get_available_segment_count(session) #42523

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
623582b
test(dataset): update available_segment_count test to use explicit se…
Ultroncn Sep 18, 2026
787aa3b
refactor(dataset): replace available_segment_count property with get_…
Ultroncn Sep 18, 2026
caa2634
[autofix.ci] apply automated fixes
autofix-ci[bot] Sep 18, 2026
bbad351
Merge branch 'main' into refactor/dataset-available-segment-count
asukaminato0721 Sep 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions api/models/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@

from .account import Account
from .base import Base, TypeBase
from .engine import db
from .enums import (
CollectionBindingType,
CreatorUserRole,
Expand Down Expand Up @@ -224,10 +223,9 @@ def get_available_document_count(self, *, session: Session) -> int:
or 0
)

@property
def available_segment_count(self):
def get_available_segment_count(self, *, session: Session) -> int:
return (
db.session.scalar(
session.scalar(
select(func.count(DocumentSegment.id)).where(
DocumentSegment.dataset_id == self.id,
DocumentSegment.status == "completed",
Expand Down
2 changes: 1 addition & 1 deletion api/tests/test_containers_integration_tests/models/test_dataset_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ def test_dataset_available_segment_count(self, db_session_with_containers: Sessi
db_session_with_containers.add(seg_waiting)
db_session_with_containers.flush()

assert dataset.available_segment_count == 2
assert dataset.get_available_segment_count(session=db_session_with_containers) == 2

def test_document_segment_count_property(self, db_session_with_containers: Session) -> None:
"""Test document can count its segments."""
Expand Down
Loading