[keith991001]

Part of #40372 (claimed in #40372 (comment)). This removes the last raw db.session read in api/models/: _resolve_workflow_app_tenant_id.

Summary

WorkflowDraftVariable's value decoding chain (get_value → _loads_value → build_segment_from_serialized_value → _rebuild_file_types → _resolve_workflow_app_tenant_id) resolved the app's tenant through the global db.session. The whole chain now takes an explicit session: Session.

Call sites

• WorkflowDraftVariableService: passes its own _session (4 sites).
• DraftVarLoader.load_variables: restructured — the decode loop moves inside the session block that loaded the variables (previously it decoded after that session closed, which only worked because of the global-session fallback), and the two passes over draft_vars merge into one. _load_offloaded_variable runs on a thread pool, so each call opens its own short-lived session instead of sharing one.
• The implicit reader in fields/workflow_draft_variable_fields.py (_serialize_var_value via dump_response) gets WorkflowDraftVariableResponseSource on the shared SessionResponseSource base from refactor(models): pass session into WorkflowRun accessors and drop dead ones #42034; the three draft-variable controllers wrap at their dump_response boundaries with the session each handler already holds (@with_session in the snippet controller, the handler's existing session otherwise).
• A bare WorkflowDraftVariable handed to the value-carrying response now raises a TypeError instead of silently falling through from_attributes and exposing the raw serialized JSON string as the value.

get_value()'s caching contract is unchanged: the first call decodes with the caller's session and later calls hit the cache.

Verified: ruff clean; pyrefly reports zero errors for every symbol in the chain repo-wide; 11,651 unit tests pass locally (controllers + models + services + fields), including the previously-missed workflow_draft_variables_test.py serialization tests, which are updated to use the response source with the sqlite_session fixture.

From Claude Code

[github-actions]

Pyrefly Diff

base → PR

--- /tmp/pyrefly_base.txt	2026-09-29 03:26:58.203644068 +0000
+++ /tmp/pyrefly_pr.txt	2026-09-29 03:26:49.415447728 +0000
@@ -1885,7 +1885,7 @@
 ERROR Unexpected keyword argument `app_id` in function `Handler.get` [unexpected-keyword]
    --> tests/unit_tests/controllers/console/app/test_wraps.py:126:37
 ERROR Cannot set item in `OrderedDict[str, bool | list[str] | str]` [unsupported-operation]
-   --> tests/unit_tests/controllers/console/app/workflow_draft_variables_test.py:136:47
+   --> tests/unit_tests/controllers/console/app/workflow_draft_variables_test.py:144:47
 ERROR Object of class `FromClause` has no attribute `create` [missing-attribute]
   --> tests/unit_tests/controllers/console/datasets/rag_pipeline/test_rag_pipeline.py:83:9
 ERROR Object of class `FromClause` has no attribute `create` [missing-attribute]
@@ -6263,7 +6263,7 @@
 ERROR Argument `None` is not assignable to parameter `value` with type `SQLCoreOperations[str] | str` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
    --> tests/unit_tests/models/test_tool_models.py:603:47
 ERROR Object of class `WorkflowDraftVariable` has no attribute `_WorkflowDraftVariable__value` [missing-attribute]
-   --> tests/unit_tests/models/test_workflow.py:445:9
+   --> tests/unit_tests/models/test_workflow.py:447:9
 ERROR Argument `None` is not assignable to parameter `graph` with type `str` in function `models.workflow.Workflow.new` [bad-argument-type]
    --> tests/unit_tests/models/test_workflow_models.py:938:19
 ERROR Class member `TestAliyunOss.setup_method` overrides a member in a parent class but is missing an `@override` decorator [missing-override-decorator]
@@ -6799,13 +6799,13 @@
 ERROR Argument `None` is not assignable to parameter `value` with type `SQLCoreOperations[UploadFile] | UploadFile` in function `sqlalchemy.orm.base.Mapped.__set__` [bad-argument-type]
    --> tests/unit_tests/services/workflow/test_draft_var_loader_simple.py:153:37
 ERROR Argument `Literal['opendal']` is not assignable to parameter `storage_type` with type `StorageType` in function `models.model.UploadFile.__init__` [bad-argument-type]
-   --> tests/unit_tests/services/workflow/test_draft_var_loader_simple.py:178:26
+   --> tests/unit_tests/services/workflow/test_draft_var_loader_simple.py:242:26
 ERROR Argument `Literal['account']` is not assignable to parameter `created_by_role` with type `CreatorUserRole` in function `models.model.UploadFile.__init__` [bad-argument-type]
-   --> tests/unit_tests/services/workflow/test_draft_var_loader_simple.py:184:29
+   --> tests/unit_tests/services/workflow/test_draft_var_loader_simple.py:248:29
 ERROR Argument `Literal['opendal']` is not assignable to parameter `storage_type` with type `StorageType` in function `models.model.UploadFile.__init__` [bad-argument-type]
-   --> tests/unit_tests/services/workflow/test_draft_var_loader_simple.py:230:26
+   --> tests/unit_tests/services/workflow/test_draft_var_loader_simple.py:294:26
 ERROR Argument `Literal['account']` is not assignable to parameter `created_by_role` with type `CreatorUserRole` in function `models.model.UploadFile.__init__` [bad-argument-type]
-   --> tests/unit_tests/services/workflow/test_draft_var_loader_simple.py:236:29
+   --> tests/unit_tests/services/workflow/test_draft_var_loader_simple.py:300:29
 ERROR Object of class `Iterator` has no attribute `close` [missing-attribute]
    --> tests/unit_tests/services/workflow/test_inspector_events.py:181:9
 ERROR Object of class `Iterator` has no attribute `close` [missing-attribute]

[github-actions]

Pyrefly Type Coverage

Metric	Base	PR	Delta
Type coverage	67.65%	67.67%	+0.03%
Strict coverage	67.27%	67.30%	+0.03%
Typed symbols	52,001	52,079	+78
Untyped symbols	25,011	25,017	+6
Modules	3580	3582	+2

[codecov]

Codecov Report

❌ Patch coverage is 89.91597% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.34%. Comparing base (e6f1d77) to head (be406c2).
⚠️ Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
...tasets/rag_pipeline/rag_pipeline_draft_variable.py	81.81%	4 Missing and 2 partials ⚠️
...controllers/console/app/workflow_draft_variable.py	91.89%	2 Missing and 1 partial ⚠️
...onsole/snippets/snippet_workflow_draft_variable.py	40.00%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #43112   +/-   ##
=======================================
  Coverage   88.33%   88.34%           
=======================================
  Files        5133     5133           
  Lines      324423   324427    +4     
  Branches    65349    65349           
=======================================
+ Hits       286593   286626   +33     
+ Misses      32445    32421   -24     
+ Partials     5385     5380    -5     

Flag	Coverage Δ
api	87.99% <89.91%> (+0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[asukaminato0721]

inject session here

[keith991001]

THX for ur comment! Done in 6b9af5e