Repository navigation
Conversation
Contributor
Pyrefly Type Coverage
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #44418 +/- ##
=======================================
Coverage 88.78% 88.78%
=======================================
Files 5553 5555 +2
Lines 332847 332874 +27
Branches 66591 66589 -2
=======================================
+ Hits 295503 295548 +45
+ Misses 32162 32148 -14
+ Partials 5182 5178 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #39993. Provider discovery is the independent portion of the family claimed in #39993 (comment). Agent logs are being handled separately in #43688.
Move the two Console Agent provider endpoints from the static
AgentServicemethods to an injectedAgentProviderServicewith a plugin-runtime gateway. Both handlers useconsole_account_admission; the service derives the workspace from the admittedRequestContext.Reuse the existing plugin declaration DTOs so list/detail response schemas and serialized fields stay unchanged. Provider lookup client errors retain the existing
ValueError/ 400 behavior; list and unexpected runtime failures keep their existing propagation. Add controller/application import-linter contracts.The legacy
AgentServiceremains available for the separate logs migration and compatibility callers.Validation
git diff --checkpassed.From Codex