Skip to content

feat(hitl): expose bound IM providers in contact options - #45233

Merged
QuantumGhost merged 1 commit into
langgenius:mainfrom
QuantumGhost:codex/contact-option-im-providers
Nov 1, 2026
Merged

QuantumGhost merged 1 commit into
langgenius:mainfrom
QuantumGhost:codex/contact-option-im-providers

Conversation

@QuantumGhost

Copy link
Copy Markdown
Contributor

AI disclosure: This PR was primarily drafted with Codex using gpt-6.1-sol. I have reviewed and edited the final diff, and I am responsible for the content.

Summary

Human Input v2 contact-option search and batch responses omit effective IM provider information, so recipient cards cannot display a bound platform's icon. Add the required im_providers: list[IMProvider] field to both responses, using the existing batch lookup for current effective bindings and returning distinct providers or [] when unbound.

The projection preserves workspace override precedence and describes binding presence independently of Channel connection health. Editor permissions and recipient DSL remain unchanged; the response continues to omit binding IDs, identity details and management metadata. Generated TypeScript/Zod/oRPC contracts and the Console API reference are updated.

Fixes #45232

Validation:

  • 271 focused backend controller, service, schema and OpenAPI-export tests passed.
  • 6 frontend contact-provider tests passed.
  • Scoped Ruff lint/format checks, backend Pyrefly, Contracts and Web type checks, and Vite+ formatting/lint checks passed.
  • The full make lint && make type-check and vp staged commands were not run; the corresponding checklist item remains unchecked.

Screenshots

This change adds API response data; it does not change the rendered UI.

Before After
Contact options omit IM provider information. Contact options include im_providers: ["feishu"], or [] when unbound.

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've verified the change and added or updated tests where meaningful regression risk justifies coverage.
  • I've updated the documentation accordingly.
  • I ran make lint && make type-check (backend) and vp staged (frontend) to appease the lint gods

From Codex

Include distinct effective IM providers in contact option search and batch
responses. Regenerate API contracts and cover provider projection and editor
permissions.

Assisted-by: Codex:gpt-6.1-sol
@github-actions github-actions Bot added size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web. labels Nov 1, 2026
@codecov

codecov Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.85%. Comparing base (c828675) to head (4b209a8).
⚠️ Report is 78 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #45233      +/-   ##
==========================================
+ Coverage   89.79%   89.85%   +0.06%     
==========================================
  Files        6239     6249      +10     
  Lines      396366   398128    +1762     
  Branches    79954    80223     +269     
==========================================
+ Hits       355924   357753    +1829     
+ Misses      34141    34064      -77     
- Partials     6301     6311      +10     
Flag Coverage Δ
api 89.72% <100.00%> (+0.08%) ⬆️
cli 94.26% <ø> (ø)
dify-ui 92.64% <ø> (ø)
web 89.83% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Nov 1, 2026

Copy link
Copy Markdown
Contributor

Pyrefly Type Coverage

Metric Base PR Delta
Type coverage 81.60% 81.61% +0.00%
Strict coverage 81.25% 81.25% +0.00%
Typed symbols 85,638 85,643 +5
Untyped symbols 19,389 19,389 0
Modules 4396 4397 +1

@QuantumGhost
QuantumGhost added this pull request to the merge queue Nov 1, 2026
Merged via the queue into langgenius:main with commit 9dd087b Nov 1, 2026
58 checks passed
@QuantumGhost
QuantumGhost deleted the codex/contact-option-im-providers branch November 1, 2026 07:59
QuantumGhost added a commit that referenced this pull request Nov 1, 2026
Preserve the build branch history and include the latest upstream/main
and the contact option IM provider projection from PR #45233.

Assisted-by: Codex:gpt-6.1-sol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files. web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Expose effective IM providers in Human Input v2 contact options

2 participants