Skip to content

Add proper documentation and warning for flux users - #1270

Merged
pagrubel merged 7 commits into
developfrom
flux-import-issue
Oct 27, 2026
Merged

pagrubel merged 7 commits into
developfrom
flux-import-issue

Conversation

@sbzeytun

Copy link
Copy Markdown
Collaborator

This addresses issue #1269.

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Coverage: 69.60%

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Coverage: 69.61%

@pagrubel

Copy link
Copy Markdown
Collaborator

I changed the command to test the flux environment, since it did not work for me on the system I was on.
Also, the warnings don't show up. The error shows up in the log files.
All the user sees is that the task stays in "SUBMIT" stage. We may need to do the sanity test and then give the user a warning.

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Coverage: 69.61%

@sbzeytun

Copy link
Copy Markdown
Collaborator Author

Okay, sounds good. I will do that now.

@pagrubel

Copy link
Copy Markdown
Collaborator

It worked when I changed the test to "from flux import job" instead of "import flux"
line number 363

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Coverage: 69.61%

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report

Coverage: 69.61%

@pagrubel pagrubel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thank you! My minor fixes only changed documentation, so I am going to approve this and merge it.

@pagrubel
pagrubel merged commit eed4dbc into develop Oct 27, 2026
7 checks passed
@pagrubel
pagrubel deleted the flux-import-issue branch October 27, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants