Repository navigation
CI: run full CI matrices on failures - #144
Open
tylerjereddy wants to merge 1 commit into
Open
tylerjereddy wants to merge 1 commit into
tylerjereddy wants to merge 1 commit into
Conversation
* We've have CI failures plaguing us for months now (lanlgh-117, lanlgh-98, and others), and for GitHub Actions matrix jobs, when one entry in the matrix fails the rest of the jobs are then cancelled. This makes it hard for the reviewer to assess if new problems have been introduced to CI jobs that are not running. * This small patch allows all CI jobs in GHA matrices to run to completion, whether other matrix members fail or not, to make it easier for reviewers to assess what is going on. * This is pretty commonly used as one can see from other well-maintained repositories. For example, `git grep -E -i "fail-fast"` in the latest `main` branch of NumPy shows many uses of `fail-fast: false`.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've have CI failures plaguing us for months now (TST, CI:
test_partial_fitis failing in Linux CI (with NumPy2.5.0) #117, TST, CI:test_regression_bostonsometimes failing in CI #98, and others), and for GitHub Actions matrix jobs, when one entry in the matrix fails the rest of the jobs are then cancelled. This makes it hard for the reviewer to assess if new problems have been introduced to CI jobs that are not running.This small patch allows all CI jobs in GHA matrices to run to completion, whether other matrix members fail or not, to make it easier for reviewers to assess what is going on.
This is pretty commonly used as one can see from other well-maintained repositories. For example,
git grep -E -i "fail-fast"on the latestmainbranch of NumPy shows many uses offail-fast: false.AI usage disclosure: I asked Opus
5.5to adjust all GHA config files with matrix usage accordingly.