remove tl tag - #153
Open
mstrelan wants to merge 1 commit into
Open
Conversation
larowlan
reviewed
Jul 8, 2026
| $slots->addColumn('tid', 'bigint', ['unsigned' => TRUE]); | ||
| $slots->addColumn('teid', 'bigint', ['unsigned' => TRUE])->setNotnull(FALSE); | ||
| $slots->addColumn('comment', 'string', ['length' => 255])->setNotnull(FALSE); | ||
| $slots->addColumn('category', 'string', ['length' => 255])->setNotnull(FALSE); |
Owner
There was a problem hiding this comment.
I think these changes will trigger a schema update which from memory doesn't work - can we just keep the column and it will be null?
Collaborator
Author
There was a problem hiding this comment.
It just prompts you to run tl install and that seems to update the schema
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the concept of tagging, and hardcodes
'activity_id' => 9for the redmine connector. I don't know if 9 is significant or the LLM just chose it for fun, but I don't really know anything about redmine to verify. We could probably have a follow up to remove redmine.