Repository navigation
Move the JDK variant's JUnit console launcher to 1.14.4, the last JUnit 5 release (#194) - #246
Merged
Merged
Conversation
…it 5 release (#194) ## What `JUNIT_CONSOLE_VERSION` goes from 1.13.4 to 1.14.4, with its sha256. It is the last 1.x entry in Maven Central's maven-metadata.xml; 6.x, the JUnit 6 line, stays out of scope. The new ARG values invalidate the guarded RUN's cache, so the next variant build fetches the new jar and runs its self-test. The default image is unaffected. The jar's `META-INF/shadowed-artifacts` differs from 1.13.4's only in the twelve JUnit versions: Jupiter and Vintage are now 5.14.4, Platform 1.14.4. It still bundles JUnit 4.13.2, hamcrest-core 1.3, opentest4j, apiguardian-api and open-test-reporting-tooling-spi, and still not testkit. The README's Maven exclusion list therefore stays correct, and NOTES.md says the list holds for both versions. Its size and memory figures stay labelled 1.13.4. The Dockerfile's bump comment now asks for the `.asc` check as well as the `.sha256`, which shares the jar's host. ## Checked - `make lint`, `make consistency` and `make test` pass. - The sha256 equals the published `.sha256`, and the jar also matches the published `.sha512` and `.sha1`. The `.asc` verifies as a good signature from FF6E2C001948C5F2F38B0CC385911F425EC61B51 (Marc Philipp), the same key that verifies 1.13.4, whose published sha256 equals the pin being replaced. The key was fetched in the container; that the fingerprint is JUnit's release key was not checked against a second source. - The bundled list comes from the downloaded jar's `META-INF/shadowed-artifacts`. - The console options the image and the README use are unchanged: `execute`, `--scan-class-path`, `--class-path`, `--fail-if-no-tests` and `--disable-banner`. The version line's format, `JUnit Platform Console Launcher %s`, is unchanged. The class-file levels equal 1.13.4's, so Java 8 is still the minimum. - The 5.14.0–5.14.4 release notes name two console changes: a warning for a classpath root that does not exist (5.14.0), and JDK 26 compatibility (5.14.2). Neither affects the commands used here. - On the maintainer's host, from a temporary worktree at this commit: `SANDBOX_JDK=21 ./run-claude-sandbox.sh --build-only` rebuilt the variant. That build fetched the jar, checked its digest and ran the self-test. The built image's `/etc/claude-code/jdk-version` reads `javac 21.0.13` and `JUnit Platform Console Launcher 1.14.4`; main's build read 1.13.4. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
JUNIT_CONSOLE_VERSIONgoes from 1.13.4 to 1.14.4, with its sha256. It is the last1.x entry in Maven Central's maven-metadata.xml; 6.x, the JUnit 6 line, stays out of
scope. The new ARG values invalidate the guarded RUN's cache, so the next variant
build fetches the new jar and runs its self-test. The default image is unaffected.
The jar's
META-INF/shadowed-artifactsdiffers from 1.13.4's only in the twelveJUnit versions: Jupiter and Vintage are now 5.14.4, Platform 1.14.4. It still bundles
JUnit 4.13.2, hamcrest-core 1.3, opentest4j, apiguardian-api and
open-test-reporting-tooling-spi, and still not testkit. The README's Maven
exclusion list therefore stays correct, and NOTES.md says the list holds for both
versions. Its size and memory figures stay labelled 1.13.4. The Dockerfile's bump
comment now asks for the
.asccheck as well as the.sha256, which shares thejar's host.
Checked
make lint,make consistencyandmake testpass..sha256, and the jar also matches the published.sha512and.sha1. The.ascverifies as a good signature fromFF6E2C001948C5F2F38B0CC385911F425EC61B51 (Marc Philipp), the same key that verifies
1.13.4, whose published sha256 equals the pin being replaced. The key was fetched
in the container; that the fingerprint is JUnit's release key was not checked
against a second source.
META-INF/shadowed-artifacts.execute,--scan-class-path,--class-path,--fail-if-no-testsand--disable-banner.The version line's format,
JUnit Platform Console Launcher %s, is unchanged.The class-file levels equal 1.13.4's, so Java 8 is still the minimum.
does not exist (5.14.0), and JDK 26 compatibility (5.14.2). Neither affects the
commands used here.
SANDBOX_JDK=21 ./run-claude-sandbox.sh --build-onlyrebuilt the variant. Thatbuild fetched the jar, checked its digest and ran the self-test. The built image's
/etc/claude-code/jdk-versionreadsjavac 21.0.13andJUnit Platform Console Launcher 1.14.4; main's build read 1.13.4.Generated with Claude Code