test: use non-destructive runner for readonly suite - #73
Merged
Conversation
The post_deploy_functional_readonly suite called lib.RunSetupTestTeardown, which applies and destroys infrastructure -- so the 'read-only' suite was not actually read-only. Switch it to lib.RunNonDestructiveTest. The testimpl function is unchanged and already satisfies the TestComposable* requirement. CI never executes this suite (make test excludes post_deploy_functional_readonly), so this defect was invisible. Background: launchbynttdata/launch-workflows#92. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ben-vaughan-nttd
approved these changes
Jun 30, 2026
ben-vaughan-nttd
left a comment
ben-vaughan-nttd
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the one-line readonly suite runner change. This correctly switches the post_deploy_functional_readonly test from lib.RunSetupTestTeardown to lib.RunNonDestructiveTest, which matches the intended non-destructive behavior for readonly Terratest packages.
No issues found. Checks are passing.
Note: This pull request review was generated by Codex.
chris11-taylor-nttd
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
tests/post_deploy_functional_readonlysuite calledlib.RunSetupTestTeardown, which applies and destroys infrastructure — so the "read-only" suite was not actually read-only. This switches it tolib.RunNonDestructiveTest.Why it was invisible
make testexcludespost_deploy_functional_readonly(go list ./tests/... | grep -v post_deploy_functional_readonly), so CI never runs this suite and the wrong runner passed unnoticed. Background: launchbynttdata/launch-workflows#92.Scope / safety
TestComposable*requirement ofRunNonDestructiveTest.Part of a fleet-wide cleanup of converted-cohort "wrong runner" readonly suites (see #36 for the pilot).
Generated with Claude Code