fix!: Make AgentGraph traversal topological - #1830
Open
mattrmc1 wants to merge 6 commits into
Open
Conversation
Contributor
|
@launchdarkly/js-sdk-common size report |
Contributor
|
@launchdarkly/js-client-sdk-common size report |
Contributor
|
@launchdarkly/browser size report |
Contributor
|
@launchdarkly/js-client-sdk size report |
mattrmc1
marked this pull request as ready for review
July 29, 2026 21:54
andrewklatzke
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes
AgentGraphDefinitiontraversal topological and gives each visitor a dependency-scopedexecution context, aligning the traversal behavior across the LaunchDarkly AI SDKs.
Previously
traverse/reverseTraversewere plain BFS over a single shared, accumulating contextmap. That had two problems:
discovery — before all of its predecessors had run. (e.g. root
RwithR→A→DandR→B→C→Dprocessed
DbeforeC, even thoughChands off toD.)(including unrelated parallel branches), and results were written back into the caller's
initialExecutionContext.What changed
packages/sdk/server-ai—AgentGraphDefinition.tsonly (no public API/signature changes):traversenow visits a node only after all of its reachable predecessors have been visited(Kahn over in-degree; the root is always released first). On cycles, the unvisited node with the
lowest remaining in-degree is chosen next, ties broken by discovery order.
reverseTraversenow visits a node only after all of its reachable descendants have beenvisited, so the root is visited last (Kahn over out-degree, root excluded from cycle-break
selection). Pure cycles now visit every node instead of being a no-op.
initialExecutionContextplus onlythat node's true dependency results (transitive ancestors forward / descendants reverse). Results
are kept in a private map keyed by node; unrelated branches and self-loops are excluded, and the
caller's map is never mutated. Cross-node data flows only through callback return values.
order) via
_reachableAndDiscovery, used only for tie-breaks — so order never depends on objectkey enumeration.
Behavior change (breaking)
Titled
fix!because visit order and callback-context contents change for graphs with convergentpaths, cycles, or parallel branches. Simple linear graphs are unaffected. Cross-SDK parity with
JS/Python/.NET/Java.
Tests
G1–G6(+G2b) assert exact visit order and exact contextkeys in both directions.
mutated; unrelated branches excluded; self-loop excluded from its own context; deterministic across
runs.
Notes
CHANGELOG.mdedit — release-please generates it from the conventional-commit title.Note
High Risk
Marked breaking (
fix!): orchestration order and what each node sees inexecutionContextchange for convergent paths, cycles, and parallel branches—apps that relied on old BFS order or a global context map may behave differently.Overview
Breaking change:
AgentGraphDefinition.traverseandreverseTraverseno longer use plain BFS with one shared, growingexecutionContext. They now use topological ordering (Kahn-style over in-/out-degree, with BFS discovery order for ties and cycle breaks) so convergent nodes run only after all predecessors or descendants, and pure cycles are fully visited on reverse instead of being a no-op.Each callback gets a fresh context:
initialExecutionContextplus only that node’s transitive predecessors (forward) or descendants (reverse)—parallel branches no longer leak into each other, and the caller’s initial map is not mutated; results live in a private map keyed by node.Tests add shared G1–G6 / G2b vectors for exact visit order and context keys; the create-agent-graph README describes topological vs reverse-topological traversal.
Reviewed by Cursor Bugbot for commit d4656bf. Bugbot is set up for automated code reviews on this repo. Configure here.