chore: Remove unused imports from the client and data system modules - #504
Merged
Conversation
keelerm84
approved these changes
Aug 19, 2026
jsonbailey
added a commit
that referenced
this pull request
Aug 19, 2026
The rebase over #504 (unused-import cleanup) silently dropped Any, Callable, and VersionedDataKind from fdv2.py — they were unused on main before the read-only store view existed, so the auto-merge removed them even though the view's signatures depend on them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes pre-existing unused imports flagged by pyflakes in
ldclient/client.py,ldclient/impl/datasystem/fdv1.py, andldclient/impl/datasystem/fdv2.py.No functional change and no changelog impact — only import lines were touched.
Note: this overlaps
fdv1.py/fdv2.pywith PR #503, which also touches those files. Whichever merges second will need a straightforward import-line rebase.Note
Overview
Cleanup only: removes unused imports flagged by pyflakes in
client.py,fdv1.py, andfdv2.py—no behavior changes.In
client.py, drops datasource/datastore status impl imports (DataSourceStatusProviderImpl,DataSourceUpdateSinkImpl,DataStoreStatusProviderImpl,DataStoreUpdateSinkImpl),Listeners, and unusedReadOnlyStorefrom the interfaces import.In
fdv1.pyandfdv2.py, removes unusedFlagTrackerImpl/FlagTrackerimports;fdv2.pyalso trims unused typing symbols andVersionedDataKind.May overlap import lines with PR #503 on the same fdv files—whichever merges second may need a small rebase on those lines.
Reviewed by Cursor Bugbot for commit b68bf89. Bugbot is set up for automated code reviews on this repo. Configure here.