Consolidate redundant Python test scaffolding - #161
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repeated Python test setup obscures the cases being checked. Consolidate the backend-resolution, model-selection and terminal-result tests into explicit parameter tables, share temporary Codex configuration setup, and use one event loop for the Grok stream. This removes a net 226 lines across six test files.
The existing inputs and runtime assertions remain covered:
Remove the unused journal helper and fake-process fields/methods that finalization never reads. Drop the assertion that the legacy alias package must contain exactly two source files; its module identity, monkeypatching, command-line compatibility and process-recognition tests remain. The changed files collect 101 cases versus 99 previously because the existing pricing input variations are now separate cases.
Validation: all 101 tests in the changed files passed, whole-repository Python lint passed, and diff checks passed. Existing CI workflow checks cover the full Linux Python suite and the three supported TypeScript hosts. This is a tests-only cleanup; runtime and documentation files are unchanged.