refactor: flatten runner and vertical access, remove 1029 lines - #162
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CLI adapter loaded its only supported runner through a string-keyed dependency dictionary and probed fields to accommodate obsolete test doubles. Vertical consumers repeatedly converted the same provider through individual accessor functions. Use the bundled runner's real types and read the validated
VerticalContractdirectly, reusing it within each operation.VerticalContract. Keep the legacy accessor names imported by the current communityargus-verticalsrepository; remove the remaining unused forwarding API.450b3138: 1,029 lines (1,530 removed, 501 added), including 376 production Python lines. No code relocation or generated-file deletion contributes to that total.Validation: Ruff and
git diff --checkpass;npm run checkpasses all 226 tests. The local full Python suite completed with 11,383 passed and 97 skipped. Four install-state tests conflicted with the shared environment’s preinstalled community package; all four passed in a fresh virtual environment. CI runs the full suite without that extra package. All 24 usage-record fixture scenarios were compared against the baseline to verify identical effective inputs.Documentation: update the runtime maintenance guide with the direct loader/contract paths and compatibility scope. CI/workflow: no workflow changes; require the existing Linux Python suite and Linux/macOS/Windows TypeScript and ownership checks before merging. No service deployment or restart is included.