Fix bust % double-counting in play mode cheater view - #27
Merged
Merged
Conversation
getEffectiveDealtCards() already includes current round hands, so passing allPlayerData to getRemainingCards caused current cards to be subtracted twice, making the denominator too low and bust % too high. Closes FLI-16 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getEffectiveDealtCards()already includes current round hands + cancelled cards, butcalculateBustChancewas also subtracting them viaallPlayerData, causing current cards to be removed twice from the remaining count{}asallPlayerDatasincedealtalready accounts for all in-play cards — fixes both the cheater banner display and CPU strategy decisionsTest plan
Closes FLI-16
🤖 Generated with Claude Code