Skip to content

feat(ProbabilisticTheory): effects - #1668

Open
TomOleDiem wants to merge 11 commits into
leanprover-community:masterfrom
TomOleDiem:probabilistic-theory-effects
Open

TomOleDiem wants to merge 11 commits into
leanprover-community:masterfrom
TomOleDiem:probabilistic-theory-effects

Conversation

@TomOleDiem

@TomOleDiem TomOleDiem commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Depends on #1667 (order-unit spaces) — please review that first.

  • Effect/Basic.lean: Effect E, the sub-unit interval {0 ≤ A ≤ 1} of an order-unit space, i.e. the possible outcomes of a yes/no test.
  • Effect/Convex.lean: convex/affine mixing of effects.
  • Effect/Metric.lean: the order-unit-norm metric on effects.
  • Effect/Complement.lean: the complementary effect 1 - e.
  • Effect/Sharp.lean: sharp (projection-like) effects.

TomOleDiem and others added 4 commits August 15, 2026 20:45
# Conflicts:
#	PhyslibAlpha/Mathematics/LadderSystem/Basic.lean
#	PhyslibAlpha/Mathematics/LadderSystem/Irreducibility.lean
#	PhyslibAlpha/Mathematics/LadderSystem/OccupationBasis.lean
#	PhyslibAlpha/Mathematics/LadderSystem/SymmetricPower.lean
#	PhyslibAlpha/Mathematics/LadderSystem/Vacuum.lean
#	PhyslibAlpha/QuantumMechanics/HarmonicOscillator/Basic.lean
#	PhyslibAlpha/QuantumMechanics/HarmonicOscillator/LadderOperators.lean
#	PhyslibAlpha/QuantumMechanics/HarmonicOscillator/Vacuum.lean
Adds the order-unit foundation for a general probabilistic theory:
IsOrderUnit/IsOrderUnitElement (OrderUnit/Basic.lean), the positive
cone and its order-unit-shift lemma (OrderUnit/Cone.lean), and the
Archimedean order-unit norm with its induced normed-space structure
and order-closed topology (OrderUnit/Archimedean.lean).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@github-actions github-actions Bot added the large label Sep 20, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for this pull-request (PR). If this is your first PR, welcome to the community!

Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.

  1. Some automated checks will be run on your PR. You can see the results of these checks at the buttom of your PR page. If any of these checks fail, you will need to fix the issues before your PR can be merged. You can learn more about these here, including how to run them locally, which is sometimes quicker than relying on the GitHub Actions. If you have never had a PR merged before, you may have to wait for a reviewer to manually start these checks (this is for security).

  2. A reviewer will look at your PR and may ask you to make changes. This may happen a couple of days after you submit your PR, so you may need to be patient. But it should not be longer than that - if it is please bring it to the attention of the community on the Zulip. The level of review will depend on where your PR is submitted. If it is submitted to ./Physlib or ./QuantumInfo, the review will be more thorough than if it is submitted to ./PhyslibAlpha. You can find out more about what the review process is looking for in our review guidelines. If a reviewer adds an awaiting-author label to your PR, address the review comments, then please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

  3. The reviewer will either approve your PR, or request more changes (in which case we return to step 2). Once your PR is approved, it will be merged by a maintainer, this should happen shortly after approval, though you may get more comments at this stage.

Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages.

If you have any problems or questions, please reach out to the community on the Zulip.

- IsOrderUnitElement is now a class with named fields (nonneg,
  exists_nsmul_le) instead of a def unfolding to an And, per review.
- ArchimedeanOrderUnitSpace.closedIciTopology is now an instance
  (was a lemma) so it's found by typeclass search once the
  order-unit-norm NormedAddCommGroup is installed locally via letI.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@TomOleDiem
TomOleDiem force-pushed the probabilistic-theory-effects branch from 1ac2e95 to 13a2e08 Compare September 23, 2026 19:15
[OrderedVectorSpace E] [One E] was repeating identically across four
Effect files. Give it its own class, OrderedVectorSpaceWithUnit, and
have OrderUnitSpace extend it instead of extending both directly.
Purely internal: OrderUnitSpace's public API is unchanged.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@TomOleDiem
TomOleDiem force-pushed the probabilistic-theory-effects branch from 13a2e08 to 642dafb Compare September 23, 2026 19:50
Per feedback: prefer using OrderUnitSpace uniformly in Effect files
over introducing a new intermediate class for the recurring
[OrderedVectorSpace E] [One E] combo.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@TomOleDiem
TomOleDiem force-pushed the probabilistic-theory-effects branch from 642dafb to cf66884 Compare September 23, 2026 19:54
TomOleDiem and others added 4 commits September 23, 2026 22:01
…itSpace

IsOrderUnitElement was only ever instantiated at A = 1 (as the type of
OrderUnitSpace.isOrderUnitElement_one), so the indirection bought
nothing. Fold its two fields (nonneg, exists_nsmul_le) directly into
OrderUnitSpace as one_nonneg and exists_nsmul_one_le.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Adds effects (Effect/Basic.lean, the sub-unit interval of E), their
convex/affine structure and metric (Effect/Convex.lean,
Effect/Metric.lean), complementation (Effect/Complement.lean), and
sharp effects (Effect/Sharp.lean), building on the order-unit
foundation from leanprover-community#1667.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ic overview

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Effect/{Basic,Complement,Convex,Metric,Sharp}.lean used the granular
pre-review typeclass bundle (AddCommGroup + PartialOrder +
IsOrderedAddMonoid + Module + PosSMulMono + One + IsOrderUnit) and the
old IsOrderUnit/IsArchimedeanOrderUnit names. Switch to the merged
OrderUnitSpace/ArchimedeanOrderUnitSpace classes uniformly, dropping
the omit-tag dance that the granular version needed.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@TomOleDiem
TomOleDiem force-pushed the probabilistic-theory-effects branch from cf66884 to a9d86ab Compare September 23, 2026 20:02

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-PR This PR depends on another PR large

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants