refactor(Time): add manifold structure and remove TimeTransMan - #1683
Conversation
|
Thank you for this pull-request (PR). If this is your first PR, welcome to the community! Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.
Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages. If you have any problems or questions, please reach out to the community on the Zulip. |
jstoobysmith
left a comment
There was a problem hiding this comment.
Approved, and this looks good to me. Many thanks. We'll merge shortly.
Give Time a manifold structure in
Time/Basic.leanThis enables calculus on
Timewithout having to choose an arbitrary origin point first. The context is I would like to require reference frame origin and basis to be twice differentiable.Remove TimeTransMan
This resolves the TODO I had previously put on TimeTransMan.
Its root import, API-map entries, lint exemption, and references in TimeUnit documentation are also removed.