chore: fix build warnings from the v4.34.0 bump - #1685
Conversation
…ionOfMotion_tfae `List.tfae_cons_self` is deprecated in Mathlib; use `List.tfae_cons_of_mem` with `List.mem_cons_self` in the harmonic oscillator and simple pendulum `equationOfMotion_tfae`. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…eventually_ne_top, exists_liminf_zero_of_forall_liminf_le_with_UB, PosSemidef.rsmul `peel` is deprecated in Mathlib; use `filter_upwards` for the eventually-statements and `intro` for `PosSemidef.rsmul`. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
Thank you for this pull-request (PR). If this is your first PR, welcome to the community! Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.
Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages. If you have any problems or questions, please reach out to the community on the Zulip. |
Fixes the 13 warnings that remain on master after the v4.34.0 bump (#1661). No statements change.
List.tfae_cons_selfis deprecated.equationOfMotion_tfaeinClassicalMechanics/HarmonicOscillator/Basic.leanandClassicalMechanics/Pendulum/SimplePendulum/Hamiltonian.leannow usesList.tfae_cons_of_memwithList.mem_cons_self.eq_neg_curl_of_div_zeroinSpaceAndTime/Space/Derivatives/Curl.lean: removed four unusedsimp onlyarguments.peelis deprecated. InQuantumInfo/ForMathlib,Filter.leanandLimSupInf.leannow usefilter_upwards, andMatrix.lean(PosSemidef.rsmul) usesintro.CI doesn't show these warnings because
lake buildrestores unchanged modules from Lake'sartifact cache without recompiling them. I found them by compiling every module with
lake env lean. After this PR, all six edited files compile without warnings.Disclaimer: noticed some warnings while building that I think the version bump missed, asked
Claude to check for any build warning messages throughout Physlib, changes look reasonable.
🤖 Generated with Claude Code