Skip to content

chore: fix build warnings from the v4.34.0 bump - #1685

Merged
zhikaip merged 3 commits into
masterfrom
fix_build_warnings
Sep 24, 2026
Merged

zhikaip merged 3 commits into
masterfrom
fix_build_warnings

Conversation

@zhikaip

@zhikaip zhikaip commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator

Fixes the 13 warnings that remain on master after the v4.34.0 bump (#1661). No statements change.

  • List.tfae_cons_self is deprecated. equationOfMotion_tfae in
    ClassicalMechanics/HarmonicOscillator/Basic.lean and
    ClassicalMechanics/Pendulum/SimplePendulum/Hamiltonian.lean now uses
    List.tfae_cons_of_mem with List.mem_cons_self.
  • eq_neg_curl_of_div_zero in SpaceAndTime/Space/Derivatives/Curl.lean: removed four unused
    simp only arguments.
  • peel is deprecated. In QuantumInfo/ForMathlib, Filter.lean and LimSupInf.lean now use
    filter_upwards, and Matrix.lean (PosSemidef.rsmul) uses intro.

CI doesn't show these warnings because lake build restores unchanged modules from Lake's
artifact cache without recompiling them. I found them by compiling every module with
lake env lean. After this PR, all six edited files compile without warnings.

Disclaimer: noticed some warnings while building that I think the version bump missed, asked
Claude to check for any build warning messages throughout Physlib, changes look reasonable.

🤖 Generated with Claude Code

zhikaip and others added 3 commits September 24, 2026 20:45
…ionOfMotion_tfae

`List.tfae_cons_self` is deprecated in Mathlib; use `List.tfae_cons_of_mem` with `List.mem_cons_self` in the harmonic oscillator and simple pendulum `equationOfMotion_tfae`.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…eventually_ne_top, exists_liminf_zero_of_forall_liminf_le_with_UB, PosSemidef.rsmul

`peel` is deprecated in Mathlib; use `filter_upwards` for the eventually-statements and `intro` for `PosSemidef.rsmul`.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added the small label Sep 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for this pull-request (PR). If this is your first PR, welcome to the community!

Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.

  1. Some automated checks will be run on your PR. You can see the results of these checks at the buttom of your PR page. If any of these checks fail, you will need to fix the issues before your PR can be merged. You can learn more about these here, including how to run them locally, which is sometimes quicker than relying on the GitHub Actions. If you have never had a PR merged before, you may have to wait for a reviewer to manually start these checks (this is for security).

  2. A reviewer will look at your PR and may ask you to make changes. This may happen a couple of days after you submit your PR, so you may need to be patient. But it should not be longer than that - if it is please bring it to the attention of the community on the Zulip. The level of review will depend on where your PR is submitted. If it is submitted to ./Physlib or ./QuantumInfo, the review will be more thorough than if it is submitted to ./PhyslibAlpha. You can find out more about what the review process is looking for in our review guidelines. If a reviewer adds an awaiting-author label to your PR, address the review comments, then please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

  3. The reviewer will either approve your PR, or request more changes (in which case we return to step 2). Once your PR is approved, it will be merged by a maintainer, this should happen shortly after approval, though you may get more comments at this stage.

Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages.

If you have any problems or questions, please reach out to the community on the Zulip.

@morrison-daniel morrison-daniel left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morrison-daniel morrison-daniel added the ready-to-merge This PR is approved and will be merged shortly label Sep 24, 2026
@zhikaip
zhikaip merged commit a66aa3d into master Sep 24, 2026
11 checks passed
@zhikaip
zhikaip deleted the fix_build_warnings branch September 24, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge This PR is approved and will be merged shortly small

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants