Skip to content

chore: bump toolchain to v4.34.1 - #1686

Merged
jstoobysmith merged 2 commits into
masterfrom
bump-toolchain-v4.34.1
Sep 25, 2026
Merged

jstoobysmith merged 2 commits into
masterfrom
bump-toolchain-v4.34.1

Conversation

@kim-em

@kim-em kim-em commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

This PR moves the toolchain from v4.34.0 to v4.34.1, picking up that release's runtime fixes, and repins mathlib and doc-gen4 at their v4.34.1 tags (both are tagged for this patch).

No source changes were needed. lake build is clean locally, 9589 jobs.

🤖 Prepared with Claude Code

Move from v4.34.0 to v4.34.1, which carries runtime fixes, and repin mathlib
and doc-gen4 at their v4.34.1 tags. No source changes: `lake build` is clean
(9589 jobs).

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@github-actions github-actions Bot added the small label Sep 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for this pull-request (PR). If this is your first PR, welcome to the community!

Below is what will happen next. Please read carefully if you are not familiar with the process. You may open other PRs while this one is being reviewed, and can stack PRs on top of each other, so don't let these steps slow you down.

  1. Some automated checks will be run on your PR. You can see the results of these checks at the buttom of your PR page. If any of these checks fail, you will need to fix the issues before your PR can be merged. You can learn more about these here, including how to run them locally, which is sometimes quicker than relying on the GitHub Actions. If you have never had a PR merged before, you may have to wait for a reviewer to manually start these checks (this is for security).

  2. A reviewer will look at your PR and may ask you to make changes. This may happen a couple of days after you submit your PR, so you may need to be patient. But it should not be longer than that - if it is please bring it to the attention of the community on the Zulip. The level of review will depend on where your PR is submitted. If it is submitted to ./Physlib or ./QuantumInfo, the review will be more thorough than if it is submitted to ./PhyslibAlpha. You can find out more about what the review process is looking for in our review guidelines. If a reviewer adds an awaiting-author label to your PR, address the review comments, then please remove that label by adding a comment with -awaiting-author. This helps us keep track of reviews.

  3. The reviewer will either approve your PR, or request more changes (in which case we return to step 2). Once your PR is approved, it will be merged by a maintainer, this should happen shortly after approval, though you may get more comments at this stage.

Tip: The easiest way to get have a fast review is to submit a PR that is small and self-contained, and has clear documentation explaining why things are the way they are in your chages.

If you have any problems or questions, please reach out to the community on the Zulip.

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Will merge now.

@jstoobysmith jstoobysmith left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the ReadMe accordingly. Will merge once the linters pass again.

@jstoobysmith
jstoobysmith merged commit 98b69c4 into master Sep 25, 2026
9 checks passed
@jstoobysmith
jstoobysmith deleted the bump-toolchain-v4.34.1 branch September 25, 2026 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants