chore: bump to mathlib 4.33 - #147
Merged
Merged
Conversation
grunweg
commented
Aug 19, 2026
grunweg
commented
Collaborator
- more backcompat options, about respectTransparency.types
- a bunch of lemma deprecations, as usual
- remove some letI/haveI by let/have when in Prop context: found by a new mathlib linter
- remove some in fact superfluous have's
- deprecated lemmas about mfderiv of spheres
- more backcompat options, about respectTransparency.types - a bunch of lemma deprecations, as usual - remove some letI/haveI by let/have when in Prop context: found by a new mathlib linter - remove some in fact superfluous have's - deprecated lemmas about mfderiv of spheres
grunweg
commented
Aug 19, 2026
| (fun x : sphere (0 : E) 1 ↦ (x : E)) ∞ where | ||
| contMDiff := contMDiff_coe_sphere.of_le le_top | ||
| diff_injective := mfderiv_coe_sphere_injective | ||
| diff_injective := injective_mvfderiv_subtypeVal_sphere |
Collaborator
Author
There was a problem hiding this comment.
This statement is slight defeq abuse, but that defeq was pre-existing --- not a reason to hold up this PR.
Collaborator
Author
There was a problem hiding this comment.
(Besides, the long-term proper fix is to make the main statement use IsSmoothEmbedding and IsImmersion form mathlib, which can have different constructors for "injective mfderiv" or "injective mvfderiv".)
Collaborator
Author
|
Merging for the same reason as before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.