Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration test runner chooses a fresh random directory in its error handler instead of cleaning the directory used by the failed project. Setup errors therefore leak the copied project and can remove an unrelated directory with the newly chosen name. Even an invalid test configuration can trigger that unrelated cleanup before any project directory has been created.
Use Lean's
IO.FS.withTempDirto allocate each project directory and remove it after either completion or an exception. This also avoids collisions when allocating directories. Add five runner regressions covering setup failures, invalid configuration and child-process exit codes 0 and 7, and run them in CI.Validation on macOS arm64 with Lean v4.35.0-rc4:
lake build lean4export comparatorsucceeds with the exporter revision pinned inlake-manifest.json.scripts/fake-landrun.shdevelopment shim. This exercises the comparator and kernel checks; Linux sandbox enforcement was not tested.git diff --cached --checkpasses.