Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comparator currently drops a caller's
LEAN_NUM_THREADSwhen starting both sandboxed Lake builds and lean4export. This makes configured concurrency limits ineffective inside those commands. Pass the existing value through both Landrun allowlists; when the variable is absent, Landrun continues to omit it.FineEnvs/openai-math already patches these two allowlists to keep Lean builds within its sandbox's memory limit. This change removes the need for that downstream source patch.
The new regression test calls
safeLakeBuildandsafeExportwith trusted command probes and a launcher that models Landrun's environment filtering. CI runs it with thread counts 1 and 3 and with the variable unset. Before the change, both configured cases fail in both command paths; afterward all six observations pass.Validation:
lake build comparator lean4export; the three regression scenarios; all 20 existing integration projects with the pinned exporter and real Nanoda binary. Local integration validation uses the documented macOS development Landrun shim. Neither that shim nor the new filtering test double validates Linux sandbox isolation.