Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a theorem or axiom target has a different statement, Comparator currently reports only the target name. Include both exported types and their universe parameter lists in the existing mismatch error, using Lean's environment-independent expression representation. This also explains mismatches caused solely by different universe parameters.
The comparison criteria, error prefix and acceptance behavior remain unchanged. The diagnostics inspect the parsed constant values without installing declarations or loading a pretty-printing environment.
Fixes #9.
Validation:
lake build lean4export comparatorpassed with the pinned Lean v4.35.0-rc4 toolchain.lake env lean tests/StatementDiagnostics.lean: eight regressions passed, covering theorem and axiom type diagnostics, universe-only mismatches, matching statements, missing targets and differing constant kinds. The three diagnostic cases fail against the unchanged upstream comparison module; all five controls pass before and after.git diff --checkpassed.