Allow legacy workspaces to import module-system dependencies - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated workspaces use legacy Lean files. Importing a solution dependency that declares
requiresModuleSystemcurrently emits a Lake warning, while adding amoduleheader breaks imports of the generated legacy helpers.Declare
allowNonModules = truein generated package configurations, using Lake’s explicit compatibility setting. This preserves the existing visibility rules and permits module-system dependencies without changing statement-import restrictions or disabling other warnings.Validation: the generator and Lean dependency/module-path tests pass without warnings on Lean 4.33; the CLI contract test now builds a legacy solution against a local Git dependency using the module system. A cold, sandboxed LeanEval workspace importing LeanPool passes without warnings on Lean 4.35.0-rc3.