Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #657.
The comparison currently quantifies over Mathlib's
Topology.CWComplexwithout requiring Hausdorffness. This admits the non-Hausdorff counterexample described in the issue, making the requested derived adjunction and universal homology comparison incompatible.Require
T2Spacein theCWTopCatobject property, expose that assumption as an instance, and add it to the pointwise derived comparison and both homology statements. Update the pointwise wrapper to construct objects of the restricted category. All twelve holes retain their names and mathematical roles.Record this correction as statement revision 2. Preserve revision 1 in the revision history so the frozen v1 set remains valid. The digest covers the CW object property and the twelve hole signatures; its construction is documented beside the history entry. Generated workspaces are left to the repository's regeneration workflow, as requested by the contribution instructions.