Skip to content

chore: bump minimum supported macOS version to macOS 14 #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhuisi merged 1 commit into from
Oct 14, 2026
Merged

chore: bump minimum supported macOS version to macOS 14 #802

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions vscode-lean4/src/diagnostics/setupDiagnoser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ import { FileUri } from '../utils/exturi'
import { ToolchainUpdateMode, leanRunner, leanVersionRegex } from '../utils/leanCmdRunner'
import { checkParentFoldersForLeanProject, isValidLeanProject } from '../utils/projectInfo'

const minimumSupportedMacOSVersion = new SemVer('19.0.0')
// Darwin kernel version, as returned by `os.release()`. Darwin 23 is macOS 14.
const minimumSupportedMacOSVersion = new SemVer('23.0.0')
const minimumSupportedWindowsVersion = new SemVer('10.0.18362')

export type OSVersionDiagnosis =
Expand All @@ -38,7 +39,7 @@ function diagnoseOSVersion(): OSVersionDiagnosis {
if (currentVersion.compare(minimumSupportedWindowsVersion) >= 0) {
return { kind: 'NotUnsupported' }
}
return { kind: 'Unsupported', currentVersion, recommendedVersion: minimumSupportedMacOSVersion }
return { kind: 'Unsupported', currentVersion, recommendedVersion: minimumSupportedWindowsVersion }
}
return { kind: 'NotUnsupported' }
}
Expand Down
Loading