Repository navigation
[CourseRegistry] Require explicit completion integration configuration #93
Description
Description
Final course completion currently tolerates missing integration addresses by skipping badge minting or reward payout. This issue makes completion behavior explicit so production deployments cannot silently miss side effects.
User Story
As the Learnault Protocol,
I want to fail or explicitly configure completion side effects,
so that course completion never silently skips reward or badge issuance in production.
Requirements and Context
- Files:
contracts/course-registry/src/lib.rs,contracts/course-registry/src/test.rs - Define whether final completion requires
RewardPoolAddress,BadgeNftAddress, or both - If the selected integration is mandatory, revert when final completion is attempted without the configured address
- If optional behavior must remain supported, add an explicit mode flag rather than silently skipping work
Suggested Implementation
// 1. Add explicit completion integration configuration or policy flag.
// 2. On final module completion, enforce the chosen policy before side effects run.
// 3. Only allow silent skipping if the policy explicitly enables it.Acceptance Criteria
- Final completion behavior is deterministic and documented when integration addresses are missing.
- Production-mode tests fail if required completion integrations are unset.
- The contract no longer silently drops badge minting or payout side effects without policy support.
Submission Guidelines
- Branch:
feat/explicit-completion-integrations - Depends on:
[CourseRegistry] Trigger payout on course completion,[CourseRegistry] Trigger badge minting on completion - PR:
feat(course-registry): require explicit completion integration configuration
Activity
Martins-594 commentedon Jul 21, 2026
Hi, I'd like to work on this issue. I've gone through the description and acceptance criteria and I'm confident I can deliver it. I'll make sure every acceptance criterion is met and submit a clean, tested PR. Please assign it to me.
syed-ghufran-hassan commentedon Aug 1, 2026
I have added explicit completion policies (Optional/RewardRequired/BadgeRequired/BothRequired) to CourseRegistry, ensuring badge minting and reward payouts are never silently skipped in production; Optional policy maintains backward compatibility while required policies enforce integration configuration before course completion.
grantfox-oss commentedon Aug 19, 2026
🦊 GrantFox — @syed-ghufran-hassan has been assigned to this issue as part of the Third Campaign campaign!
Next steps:
Closes #93)Good luck! Track your progress on GrantFox.
syed-ghufran-hassan commentedon Aug 19, 2026
@Kaylahray can you please review as I have already raised PR #109
3m1n3nc3 commentedon Aug 29, 2026
Hi @syed-ghufran-hassan can you resolve the current conflict so we can close the issue? I have added it to the current campaign so it can be eligible for payment.
syed-ghufran-hassan commentedon Aug 29, 2026
@3m1n3nc3 I have updated the PR please check #109
grantfox-oss commentedon Aug 29, 2026
🎉 This issue has been marked as completed on GrantFox as part of the Third Campaign campaign!
@syed-ghufran-hassan's PR #109 was approved and merged by @3m1n3nc3.
🏆 @syed-ghufran-hassan: You earned 40 FoxPoints for this contribution! Your current tier: Builder (1,783 total points). Track your full progress on GrantFox.
👏 Great work, @syed-ghufran-hassan! Keep contributing to learnault.