Skip to content

Add make fast for the quickest local check - #143

Merged
Param-Harrison merged 4 commits into
mainfrom
cloud/make-fast
Nov 1, 2026
Merged

Param-Harrison merged 4 commits into
mainfrom
cloud/make-fast

Conversation

@Param-Harrison

Copy link
Copy Markdown
Contributor

Adds make fast: lint, typecheck, then scripts/check-affected.ts --base origin/main. It is the quickest local read on the first red CI step. make check stays the gate and does not call fast.

scripts/fast.test.ts asserts fast is in .PHONY, that its recipe is those three lines, and that the check recipe does not mention fast. With fast removed from the Makefile, the first two assertions fail.


Generated by Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Param-Harrison

Copy link
Copy Markdown
Contributor Author

The levels (verification) check fails in tests/structure/lab-solutions.test.ts for advanced-05 items 2 and 4. This PR does not cause it.

The lab's solution script runs grep -qF 'Bash(git push *)' against .claude/settings.json. Commit caba5f9 on main replaced that deny entry with narrower ones, so the grep now fails. This PR touches only Makefile and scripts/fast.test.ts.

No fix exists yet. The fix is in labs/advanced/05-cloud-session-guardrails.md and its expected output, which is outside this PR's scope, so I have not widened it. The review check also failed once when the Claude Code Action exited with no output. I re-ran that job once.


Generated by Claude Code

@Param-Harrison

Copy link
Copy Markdown
Contributor Author

The trunk check fails because of this PR. tests/structure/levels.test.ts reports scripts/fast.test.ts: no owner, since levels.json has no entry for the new test file.

The fix is one line in levels.json, next to scripts/check-affected.ts and scripts/impact.test.ts in the level that owns them. The task that produced this PR forbade editing levels.json, so I have not pushed it. It needs your call on which level should own the file.

The other red checks (levels (*)) fail on the lab advanced-05 problem from main, covered in my earlier comment. The review job failed again on its re-run, so the Claude Code Action looks broken independent of this PR.


Generated by Claude Code

Param-Harrison and others added 2 commits November 1, 2026 12:12
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@Param-Harrison
Param-Harrison marked this pull request as ready for review November 1, 2026 11:01
@Param-Harrison
Param-Harrison merged commit 9519a97 into main Nov 1, 2026
11 of 12 checks passed
@Param-Harrison
Param-Harrison deleted the cloud/make-fast branch November 1, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants