Repository navigation
test(gamepad): use the default runtime context - #1343
Merged
Merged
Conversation
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
新增 gamepad 事件载荷测试沿用了已移除的
page_default_context字段。测试夹具现在通过page_default_runtime.context保存默认页面 context,因此 main 及基于 main 的临时合并检查在编译测试时触发 E0609;Clippy 和 Nextest 都无法运行。修复
将测试中的 context 指针取址改为
page_default_runtime.context,与相邻的 TimeRanges、SVG geometry、canvas 和 DOMException 测试使用同一接口。保留原生品牌、代理品牌及事件载荷身份的全部断言;不改变运行时实现。验证
gamepad_interfaces.rs:23编译失败。cargo fmt --all --check通过。cargo test -p moli-renderer-v8 --locked --lib script_vm::tests::gamepad_interfaces:::两个原有场景通过,8972 个其他测试未执行。此修复基于 main 的
19f388b4f1ac11164b21969c3342789012125e09,与内容转换 #1334–#1337 独立。