Skip to content

test(canvas): use the default runtime context - #1375

Merged
ldm0 merged 1 commit into
mainfrom
codex/fix-canvas-test-runtime
Oct 10, 2026
Merged

ldm0 merged 1 commit into
mainfrom
codex/fix-canvas-test-runtime

Conversation

@lanyue-llk

Copy link
Copy Markdown
Contributor

问题

#1280 合入的 Canvas 原生代理测试仍引用 PageVmTaskExecutorTestHarness.page_default_context。当前测试执行器已将默认 V8 context 移到 page_default_runtime.context,因此 main 的测试目标无法编译,阻塞 #1334、#1335 的 Clippy 和 Nextest。

失败位置:moli-renderer-v8/src/script_vm/tests/canvas_fill_rect.rs:37,编译器报 E0609。两个 PR 的四个失败任务均为这一错误。

修复

从默认 document runtime 获取 context,沿用 credential 和 gamepad 测试已经采用的访问方式。一行修改,保留原有代理身份、像素结果、品牌检查及参数转换顺序断言。

检查了 renderer 中同名访问;其余使用属于有效的 context host 字段或方法,不需要修改。

验证

@ldm0
ldm0 merged commit cc6c5ab into main Oct 10, 2026
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants